fix(opencode): no response handling#29966
Open
SoShymKing wants to merge 7 commits into
Open
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #17717
Addresses the bug described in #17717.
This is a template-compliant follow-up to #17719, which attempted the same fix but was automatically closed for not using the required PR template.
Type of change
What does this PR do?
This addresses the unexpected abort and no-response behavior reported in #17717 and previously attempted in #17719.
When the model or provider raises an abort while the session itself has not been cancelled, OpenCode now treats that case as a transient provider/client-side abort rather than a user cancellation.
These errors are routed through the existing retry and backoff path, while explicit user or session cancellations still terminate immediately without retrying.
The change also improves handling for stalled post-tool continuations and empty assistant streams.
OpenCode now detects post-tool continuation failures after completed tool calls, converts no-response cases into typed errors with diagnostics, and retries blank or structural-only assistant turns instead of persisting them as successful empty responses.
How did you verify your code works?
Ran from 'packages/opencode':
'''bash
bun test test/session/retry.test.ts test/session/message-v2.test.ts test/session/processor-effect.test.ts
bun typecheck
'''
Screenshots / recordings
If this is a UI change, please include a screenshot or recording.
Checklist
If you do not follow this template your PR will be automatically rejected.