fix(app): align model selector keyboard navigation with visual group order - #39344
Open
DevDengChao wants to merge 1 commit into
Open
fix(app): align model selector keyboard navigation with visual group order#39344DevDengChao wants to merge 1 commit into
DevDengChao wants to merge 1 commit into
Conversation
…order The V2 model selector's keyboard navigation (up/down arrows) followed a flat alphabetical-by-model-name order, while the UI rendered models grouped by provider with groups sorted by provider popularity. This caused the highlight to jump non-linearly between provider groups when navigating filtered results. Change keys() to derive from groups().flatMap() instead of models().map() so navigation order matches the visual render order. Closes anomalyco#39341
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #39341
Type of change
What does this PR do?
The V2 model selector in the Desktop App / Web UI had a mismatch between keyboard navigation order and visual render order. When filtering models (e.g., typing "deep" to find DeepSeek models across multiple providers), pressing up/down arrows navigated in flat alphabetical-by-model-name order, while the UI rendered models grouped by provider with groups sorted by provider popularity. This caused the highlight to jump non-linearly between provider groups.
The fix changes
keys()(line 311 ofdialog-select-model.tsx) to derive fromgroups().flatMap()instead ofmodels().map(), so keyboard navigation follows the same grouped+sorted order as the visual rendering.How did you verify your code works?
dialog-select-model.test.tsverifying that navigation keys derived from grouped models match the visual provider-popularity orderbun typecheckpasses across all 36 packagesScreenshots / recordings
No UI visual changes — this is a behavioral fix only.
Checklist