fix(core): await initial plugin readiness before serving catalog reads - #40070
Open
zhang17-24 wants to merge 1 commit into
Open
fix(core): await initial plugin readiness before serving catalog reads#40070zhang17-24 wants to merge 1 commit into
zhang17-24 wants to merge 1 commit into
Conversation
Cold-start catalog reads returned a successful but partial snapshot while initial catalog-producing plugins were still activating, so a client bootstrap during that window saw incomplete providers/models as authoritative state. PluginV2 now exposes a one-shot initial-readiness barrier: the loader seals it once boot (including externally configured plugins) has finished, and provider/model read handlers await it before reading the catalog, returning 503 ServiceUnavailableError when readiness cannot complete within a bounded period.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #36117
Type of change
What does this PR do?
Cold-start catalog reads returned a successful but partial snapshot while initial catalog-producing plugins were still activating, so a client bootstrapping during that window saw incomplete providers/models as authoritative state.
PluginV2 now exposes a one-shot initial-readiness barrier (
flush/sealInitial): the internal loader seals it once boot has finished, including externally configured plugins which now finish loading before boot completes. The provider.list, provider.get, and model.list handlers await the barrier before reading the catalog, returning 503 ServiceUnavailableError when readiness cannot complete within a bounded period (10s).How did you verify your code works?
Screenshots / recordings
N/A (not a UI change)
Checklist