fix(provider): add OAuth token refresh support for GitLab provider #9949
+93
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add automatic token refresh when GitLab OAuth tokens expire during a session. Previously, expired tokens would cause 401 errors without recovery. Changes: - Add `refresh` function to AuthHook interface in plugin types - Add `ProviderAuth.refresh()` to invoke plugin refresh logic - Add custom fetch in gitlab loader to handle token refresh: - Proactively refreshes expired tokens before requests - Retries on 401 "invalid_token" errors with refreshed token This requires the external GitLab auth plugin to implement the new `refresh` hook to provide the actual token refresh logic. Fixes anomalyco#9711 Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, no duplicate PRs found |
Contributor
Author
Contributor
|
@zerone0x Thanks for the fix. I will wait until this PR has merged and add |
Contributor
|
@rekram1-node Would you mind take a look at this PR, please? |
opencode-agent
bot
force-pushed
the
dev
branch
from
00637c0 to
71e0ba2
Compare
thdxr
force-pushed
the
dev
branch
3 times, most recently
from
f1ae801 to
08fa7f7
Compare
|
Hey @rekram1-node , just wanted to bump this PR. The TOKEN_REFRESH_NEEDED error is a significant pain point when using opencode with GitLab Duo - it completely halts the session and requires a manual restart to re-authenticate, and seemingly even that doesn't always work as I'll restart opencode repeatedly and just be met with the same error. It's been a pretty huge pain point for me these past few weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add automatic token refresh when GitLab OAuth tokens expire during a session.
How verified
refreshhook to the plugin interface that allows auth plugins to handle token refreshfetchnow:Changes
refreshfunction toAuthHookinterfaceProviderAuth.refresh()to invoke plugin refresh logicfetchin gitlab loader with token refresh handlingNote
This requires the external GitLab auth plugin (
@gitlab/opencode-gitlab-auth) to implement the newrefreshhook to provide the actual token refresh logic.Fixes #9711
🤖 Generated with Claude Code