Skip to content

Conversation

@dstandish
Copy link
Contributor

@dstandish dstandish commented Dec 12, 2025

This may make it easier when handling partition-driven dags differently from non-partition-driven.

But in any case, (1) it makes the code substantially simpler and (2) most of the time it's one dag per file / process anyway. Need to test to see if any meaningful impact.

@dstandish dstandish force-pushed the handle-one-dag-at-a-time-re-last-run-info branch 3 times, most recently from e8c4c60 to 52a65e2 Compare December 16, 2025 01:16
@dstandish dstandish marked this pull request as ready for review December 16, 2025 01:19
This may make it easier when handling partition-driven dags differently from non-partition-driven.
@dstandish dstandish force-pushed the handle-one-dag-at-a-time-re-last-run-info branch from b9ff78d to c57b7b2 Compare December 16, 2025 18:46
@dstandish dstandish requested review from Lee-W and uranusjr December 19, 2025 13:35
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the single last_run_info case has already been covered by existing test cases? If not, would be nice to add one

Copy link
Contributor

@Nataneljpwd Nataneljpwd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Overall improves the maintainability of the code by shortening it and making it simpler.

@dstandish
Copy link
Contributor Author

I guess the single last_run_info case has already been covered by existing test cases? If not, would be nice to add one

Yes, I believe it is.

@dstandish dstandish merged commit f798302 into apache:main Dec 23, 2025
68 checks passed
@dstandish dstandish deleted the handle-one-dag-at-a-time-re-last-run-info branch December 23, 2025 15:05
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Jan 2, 2026
This may make it easier when handling partition-driven dags differently from non-partition-driven.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants