Skip to content

Conversation

@KH-Coder865
Copy link

Problem:

Currently, calling auth_user_oauth() outside a Flask request context triggers RuntimeError: Working outside request context. The only workaround is overriding the private _rotate_session_id method, which is not recommended.

Solution:

Add a rotate_session_id=False option to skip session rotation safely.

Implement TheOverrideFabAuthManager.create_token() that wraps the token creation in an application and request context.

This approach avoids touching private methods while enabling token generation for API clients or background processes.

Testing:

Verified token generation works without a request context.

Tested compatibility with Airflow API v2 calls.

Existing FAB authentication tests pass.

Notes:

No backwards-incompatible changes.

No new dependencies.

Closes / Related Issues:

Closes: #59600

@boring-cyborg
Copy link

boring-cyborg bot commented Dec 18, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@jscheffl
Copy link
Contributor

I assumethis is fixed with (currently un-released) #59355 ?

@vincbeck
Copy link
Contributor

vincbeck commented Jan 5, 2026

I agree with @jscheffl . Closing it

@vincbeck vincbeck closed this Jan 5, 2026
@KH-Coder865
Copy link
Author

Okay. Thanks for the confirmation.

@KH-Coder865 KH-Coder865 deleted the feat/fab-authmanager-override branch January 5, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

oauth create_token accessing session causes RuntimeError: Working outside of request context.

3 participants