Skip to content

Fix executemany support#68400

Open
BentsiLeviav wants to merge 2 commits into
apache:mainfrom
BentsiLeviav:fix-executemany-support
Open

Fix executemany support#68400
BentsiLeviav wants to merge 2 commits into
apache:mainfrom
BentsiLeviav:fix-executemany-support

Conversation

@BentsiLeviav

Copy link
Copy Markdown
Contributor

hook.insert_rows(..., executemany=True) was raising AttributeError: 'tuple' object has no attribute 'keys' because clickhouse-connect's Cursor._try_bulk_insert expected dict rows, while DbApiHook.insert_rows always passes serialized tuples (PEP 249
sequences).

Fixed in clickhouse-connect 1.3.0 (released 2026-06-11). This PR bumps the minimum requirement to >=1.3.0 across pyproject.toml, README.rst, and docs/index.rst, and adds regression tests that exercise the real cursor with tuple rows.

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Claude code


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@koletzilla

Copy link
Copy Markdown
Contributor

Looks good to me! :D

@eladkal eladkal self-requested a review June 12, 2026 07:13
@github-actions

Copy link
Copy Markdown
Contributor

uv.lock on main just moved via #68436 ("[main] Upgrade important CI environment"), commit 5f8d740 and this PR currently conflicts.

Quickest fix:

git fetch upstream main && git rebase upstream/main
rm uv.lock && uv lock
git add uv.lock && git rebase --continue
git push --force-with-lease

Automated nudge — ignore if you're not ready to rebase. This comment is updated in place on future uv.lock bumps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants