Access AgentRunResult.usage as a property in common.ai logging#68405
Open
kaxil wants to merge 1 commit into
Open
Access AgentRunResult.usage as a property in common.ai logging#68405kaxil wants to merge 1 commit into
AgentRunResult.usage as a property in common.ai logging#68405kaxil wants to merge 1 commit into
Conversation
pydantic-ai deprecated calling AgentRunResult.usage() as a method (PydanticAIDeprecationWarning); it is a property since the version range already covered by the provider floor (pydantic-ai-slim>=1.99.0 exposes both forms). Drop the parentheses at the call site and update the test mocks to set .usage as an attribute instead of a return_value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pydantic-ai deprecated calling
AgentRunResult.usage()as a method, so every agent run that goes throughlog_run_summarycurrently emits aPydanticAIDeprecationWarningin task logs. This drops the parentheses at the single call site and updates the test mocks to set.usageas an attribute instead of areturn_value.No version-floor bump is needed: the provider floor
pydantic-ai-slim>=1.99.0already exposesusageas a deprecated-callable property (both access forms work there), so property access is valid across the whole supported range. Verified by runninglog_run_summaryagainst a realAgentRunResultwithPydanticAIDeprecationWarningescalated to an error: the property form is clean and the old method-call form raises.