Paginate partitioned Dag run modal requests#68412
Open
steveahnahn wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds server-side pagination to the private UI endpoint behind the pending partitioned Dag run modal, and wires the modal table state to
limitandoffset.Why:
AssetPartitionDagRunrow before enrichment.totalwas derived from the materialized row list, so the UI had no way to page through the full filtered result set.What changed:
limitandoffsetquery parameters on/ui/partitioned_dag_runs.paginated_selectso the endpoint returns the full filteredtotalwhile enriching only the current page of rows.offsetis past the end.limitandoffsetto the generated client, and reset the dialog page index on close.Validation:
upstream/mainfailed becauselimit=2still returned["key-2", "key-1", "key-0"].TestGetPartitionedDagRuns.test_should_paginate_partitioned_dag_runs.PartitionScheduleModal.test.tsxfor initial page, next page, and close/reset query parameter wiring.limit=50&offset=0, thenlimit=50&offset=50, thenlimit=50&offset=100; the final response contained 5 rows withtotal=105.Screenshots
Was generative AI tooling used to co-author this PR?
Generated-by: Codex (GPT-5) following the guidelines
Note
✅ Ready for review · @steveahnahn →
@potiuk· 2026-06-12 13:30 UTCThanks @steveahnahn — all checks are green and this PR is marked ready for maintainer review. The ball is with the maintainers now; a maintainer will take the next look.
Automated triage — may be imperfect.