Drop stale type:ignore[override] on ExecutionAPISecretsBackend#68415
Open
dkranchii wants to merge 1 commit into
Open
Drop stale type:ignore[override] on ExecutionAPISecretsBackend#68415dkranchii wants to merge 1 commit into
dkranchii wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two
# type: ignore[override]annotations onExecutionAPISecretsBackendare no longer needed; removing them lets mypy verify the override contract
for real instead of silencing it.
aget_connection:BaseSecretsBackendhas noaget_connection(itis sync-only), so
[override]cannot fire — there is nothing tooverride.
get_connection: signature now matches the base exactly aftermulti-team added
team_nametoBaseSecretsBackend.get_connection;the override only narrows the return type to
Connection | None, whichis a covariant return and accepted. The same pattern is used without
the ignore in
providers/hashicorp/.../vault.py,providers/akeyless/.../akeyless.py, andairflow-core/.../local_filesystem.py.Internal type-only cleanup; no runtime behaviour change, no newsfragment.
Follow-up to #65347 / #67216, same pattern.
Was generative AI tooling used to co-author this PR?