Skip to content

Fix BackfillDagRun.partition_key type annotation (str, not datetime)#68432

Merged
Lee-W merged 2 commits into
apache:mainfrom
astronomer:fix-backfill-partition-key-annotation
Jun 12, 2026
Merged

Fix BackfillDagRun.partition_key type annotation (str, not datetime)#68432
Lee-W merged 2 commits into
apache:mainfrom
astronomer:fix-backfill-partition-key-annotation

Conversation

@Lee-W

@Lee-W Lee-W commented Jun 12, 2026

Copy link
Copy Markdown
Member

Why

type annotation for partition key is wrong

What

Changed the type annotation from Mapped[datetime] to Mapped[str | None] to correctly match the underlying SQLAlchemy column type.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@Lee-W Lee-W requested review from XD-DENG and ashb as code owners June 12, 2026 06:59
@Lee-W Lee-W requested review from jason810496 and uranusjr June 12, 2026 07:00
@eladkal eladkal added this to the Airflow 3.3.0 milestone Jun 12, 2026
@eladkal eladkal added the type:bug-fix Changelog: Bug Fixes label Jun 12, 2026
@Lee-W Lee-W force-pushed the fix-backfill-partition-key-annotation branch from cad474a to 98eacce Compare June 12, 2026 07:33
@Lee-W Lee-W force-pushed the fix-backfill-partition-key-annotation branch from 98eacce to 2aded98 Compare June 12, 2026 08:04
@Lee-W Lee-W merged commit 9126a64 into apache:main Jun 12, 2026
77 checks passed
@Lee-W Lee-W deleted the fix-backfill-partition-key-annotation branch June 12, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants