GH-990: [JDBC] Fix memory leak on Connection#close due to unclosed ResultSet(s) #991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ennuite
changed the title
This comment has been minimized.
This comment has been minimized.
ennuite
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
Closing a Connection when there was one or more unclosed ResultSet that had been obtained
via methods of the interface DatabaseMetaData would generate exceptions due to memory leaks.
Now, closing a Connection will first close all the ResultSet instances obtained from DatabaseMetadata
instances associated with that Connection.
Closes #990.