-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-36411: [Python] Use scikit-build-core as build backend for PyArrow and get rid of setup.py #49259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
raulcd
wants to merge
19
commits into
apache:main
Choose a base branch
from
raulcd:testing-scikit-build-core
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+198
−580
Open
GH-36411: [Python] Use scikit-build-core as build backend for PyArrow and get rid of setup.py #49259
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
9fe6b0e
POC: [Python] Testing scikit-build-core as build backend for PyArrow
raulcd 234043f
Add scikit-build-core to requirements-build.txt
raulcd 8c6b44a
Try fixing source test tests on dev PR
raulcd c391495
Update some more dependencies
raulcd d2e5d29
Try creating a wrapper backend to just copy licenses before anything …
raulcd 416478a
Remove custom build backend and just use links
raulcd 1f53770
Fix populating UPPERCASE_PYBUILD_TYPE for multi-config generators whe…
raulcd 79b2b63
Add some logging
raulcd 9646fc8
Remove unnecessary logging
raulcd d8999bb
Fix sdist
raulcd 23ffa93
Add tiny build backend wrapper on top of scikit-build-core to manage …
raulcd ce6e4c3
Import all scikit_build_core.build hooks to be available like build_w…
raulcd 5c96a75
Try to solve Windows license problems with links
raulcd b44b5bb
Some fixes on documentation, remove remnant setup.py executions and r…
raulcd 677f4ca
Ooops unsaved files
raulcd d4b9055
Remove obsolete PYARROW_BUILD_TYPE. Use and document new --config-set…
raulcd f0ccac0
Remove obsolete PYARROW_CMAKE_OPTIONS and document new --config-setti…
raulcd 1110dbe
Remove PYARROW_BUILD_VERBOSE and PYARROW_PARALLEL, document new usage…
raulcd 75d2f7f
--config-settings or --config-setting depending on pip or build
raulcd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,5 +29,5 @@ numpy>=1.16.6 | |
| pytest | ||
| pytest-faulthandler | ||
| s3fs>=2023.10.0 | ||
| setuptools>=77 | ||
| scikit-build-core | ||
| setuptools_scm>=8 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember this nuance from the meson-python branch. Looks like there we just use
-Cto pass arguments to the front-end, whether its pip or build. Maybe we should use that here and avoid this altogether?