GH-49477: [C++][Parquet] Fix multiplication overflow in PLAIN BYTE_ARRAY decoder#49478
Draft
pitrou wants to merge 1 commit intoapache:mainfrom
Draft
GH-49477: [C++][Parquet] Fix multiplication overflow in PLAIN BYTE_ARRAY decoder#49478pitrou wants to merge 1 commit intoapache:mainfrom
pitrou wants to merge 1 commit intoapache:mainfrom
Conversation
…YTE_ARRAY decoder
github-actions
bot
added
Component: Parquet
Component: C++
awaiting review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Issue found by OSS-Fuzz: https://issues.oss-fuzz.com/issues/489948953
Are these changes tested?
By forthcoming regression file, pending apache/arrow-testing#129
Are there any user-facing changes?
No.
This PR contains a "Critical Fix". Signed integer overflow is undefined behavior, so this could result in any kind of misbehavior.