GH-40128: [C++][Python] Preserve dictionaries in empty casts - #50837
Open
LarryHu0217 wants to merge 1 commit into
Open
GH-40128: [C++][Python] Preserve dictionaries in empty casts#50837LarryHu0217 wants to merge 1 commit into
LarryHu0217 wants to merge 1 commit into
Conversation
uros-b
approved these changes
Aug 10, 2026
Member
|
Fix looks narrowly scoped and properly tested, thank you @LarryHu0217! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The generic zero-length scalar fast path creates an empty output dictionary and discards categories that are still attached to the input array. Other zero-length scalar operations continue to use the existing fast path.
Testing
cpp/build-40128-auto/debug/arrow-compute-scalar-cast-test(109 tests passed)clang-format --dry-run --Werroron both changed filesgit diff --checkAI assistance
I used Codex to help inspect the executor path, prepare the focused change, and draft the regression test. I reviewed the final diff, reproduced the failure before the fix, and ran the tests above locally.
Closes #40128