GH-50849: [Python] Return correct ParquetLogicalType.type for geometry/geography - #50850
Conversation
…eometry/geography
There was a problem hiding this comment.
Pull request overview
Fixes the Python Parquet metadata binding so ParquetLogicalType.type returns the correct string for the GEOMETRY/GEOGRAPHY logical types, matching the underlying Parquet logical type enum.
Changes:
- Extend the logical type enum-to-name mapping to include GEOMETRY and GEOGRAPHY.
- Add a regression test that reads geospatial Parquet fixtures and asserts the logical type name and geo statistics accessors.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| python/pyarrow/_parquet.pyx | Adds GEOMETRY/GEOGRAPHY to the enum name mapping used by ParquetLogicalType.type. |
| python/pyarrow/tests/parquet/test_metadata.py | Adds regression coverage for geometry/geography logical types and geo statistics. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 1b004f2. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 1b004f2. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 1b004f2. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 1b004f2. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
Fix the return value of
ParquetLogicalType.typefor geometry/geography typesAre these changes tested?
Yes
Are there any user-facing changes?
Not apart from the bug fix