Skip to content

Conversation

@Searion
Copy link
Contributor

@Searion Searion commented Jan 30, 2026

What problem does this PR solve?

Issue Number: resolve 3208

Problem Summary:

error: 'const class google::protobuf::Descriptor::ExtensionRange' has no member named 'start'
in src/json2pb/json_to_pb.cpp / src/json2pb/pb_to_json.cpp

What is changed and the side effects?

Changed: protobuf version check in in src/json2pb/json_to_pb.cpp / src/json2pb/pb_to_json.cpp

in protobuf 4.xx version, start is deprecated and should be replaced. The old condition

= 4.25 version is not right
Side effects:

  • Performance effects:

  • Breaking backward compatibility:


Check List:

@wwbmmm
Copy link
Contributor

wwbmmm commented Jan 30, 2026

LGTM

@yanglimingcn
Copy link
Contributor

It appears to have changed starting from 4024000.

@wwbmmm
Copy link
Contributor

wwbmmm commented Jan 31, 2026

The issue was fixed by #3210, so I will close this PR.

@wwbmmm wwbmmm closed this Jan 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1.16.0版本在protobuf版本4.24环境编译失败

3 participants