[feature][bug] Add tcp transport event dispatcher unsched flag & fix RDMA event dispatcher unsched flag#3238
Open
MalikHou wants to merge 2 commits intoapache:masterfrom
Open
[feature][bug] Add tcp transport event dispatcher unsched flag & fix RDMA event dispatcher unsched flag#3238MalikHou wants to merge 2 commits intoapache:masterfrom
MalikHou wants to merge 2 commits intoapache:masterfrom
Conversation
…atcher unsched flag
[feature][bugfix] Add tcp transport event dispatcher unsched flag & fix RDMA event dispatcher
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Event Dispatcher Unsched Flag
What problem does this PR solve?
Problem Summary:
rdma_edisp_unsched), while TCP had no unified switch.bthread_start_urgentandbthread_start_backgroundlogic was reversed, causing behavior opposite to expected unsched semantics.What is changed and the side effects?
Changed:
event_dispatcher_edisp_unsched.EventDispatcherUnsched()helper inevent_dispatcher.{h,cpp}as single source of truth.TcpTransport::ProcessEventandRdmaTransport::ProcessEventto useEventDispatcherUnsched():false->bthread_start_urgenttrue->bthread_start_backgroundbthread_start_urgentandbthread_start_backgroundbranches were previously swapped.rdma_edisp_unschedand kept compatibility through dispatcher-layer unified check.test/brpc_event_dispatcher_unittest.cpp:event_dispatcher_unsched_by_unified_flagevent_dispatcher_unsched_by_legacy_rdma_flag(whenBRPC_WITH_RDMA)tcp_unsched_true_returns_before_onedge_finishtcp_unsched_false_blocks_caller_when_single_workerEffects:
event_dispatcher_edisp_unsched=truemay reduce immediate foreground switching of dispatcher path.rdma_edisp_unschedis deprecated.Check List: