[CALCITE-7082] CalciteSystemProperty saffron.properties lookup is unusual #4455
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To concrete things up this is what I'm suggesting as a new approach for CALCITE-7082. This implementation should (although nothing is tested) make sure that each property follows a simple priority model. Highest priority setting wins along the list:
saffron.propertiesentry inThread.currentThread().getContextClassLoader()(TCCL) accessible resource.saffron.propertiesentry inCalciteSystemPropery.class.getClassLoader()accessible resource.For comparison the current implementation is either, with a TCCL set when Calcite is first loaded:
saffron.propertiesentry insaffron.propertiesavailable via TCCL.with no TCCL set when Calcite is first loaded:
saffron.propertiesentry insaffron.propertiesavailable via Calcite loader.