[CALCITE-7774] JDBC adapter generates a GROUP BY with a constant key, which SQL Server rejects - #5257
Open
wasabii wants to merge 1 commit into
Open
[CALCITE-7774] JDBC adapter generates a GROUP BY with a constant key, which SQL Server rejects#5257wasabii wants to merge 1 commit into
wasabii wants to merge 1 commit into
Conversation
… which SQL Server rejects
|
mihaibudiu
approved these changes
Sep 12, 2026
mihaibudiu
added
the
LGTM-will-merge-soon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link
CALCITE-7774
Changes Proposed
MssqlSqlDialectnow returns false fromsupportsGroupByLiteral(), soSqlImplementor.visitRootappliesAggregateProjectConstantToDummyJoinRuleand the constant moves out of theGROUP BYinto a dummy join. SQL Server has no form ofGROUP BY <constant>it will accept, so there was nothing to fix in the unparsing.Added MSSQL expectations to
testGroupByBooleanLiteralandtestGroupByDateLiteral, which already cover Redshift and Informix for the same gate.