Fix Jenkins matrix filters#24154
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
Signed-off-by: Minh Vu <vuhoangminh97@gmail.com>
davsclaus
approved these changes
Jun 20, 2026
davsclaus
left a comment
Contributor
There was a problem hiding this comment.
Correct fix — the anyOf flattening meant selecting one dimension (platform or JDK) would match all values in the other dimension. The allOf { anyOf { ... } anyOf { ... } } nesting properly makes the two filters independent. Both Jenkinsfiles updated consistently. LGTM.
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The matrix
whenblock used one broadanyOf, so selecting a platform could also run every JDK on that platform, and selecting a JDK could also run that JDK across every platform. The filters are independent dimensions, so each dimension needs its own wildcard-or-match check.Validation
git diff --check -- Jenkinsfile Jenkinsfile.jdk26