[CELEBORN-2315] Add iterator fully-consumed validation after shuffle write#3672
Open
xumingming wants to merge 1 commit intoapache:mainfrom
Open
[CELEBORN-2315] Add iterator fully-consumed validation after shuffle write#3672xumingming wants to merge 1 commit intoapache:mainfrom
xumingming wants to merge 1 commit intoapache:mainfrom
Conversation
xumingming
force-pushed
the
iterator-fully-consumed-check
branch
from
124c250 to
5a50c71
Compare
…write Adds a post-write safety check to HashBasedShuffleWriter and SortBasedShuffleWriter: after the write loop completes, verify the input iterator was fully consumed. If records remain, kill the task with TaskKilledException. This guards against silent data loss.
xumingming
force-pushed
the
iterator-fully-consumed-check
branch
from
5a50c71 to
dbd6473
Compare
Contributor
Author
|
@gauravkm @RexXiong @SteNicholas Could you also take a look at this one? |
Contributor
Author
|
@RexXiong @SteNicholas @gauravkm Gentle ping :) |
Contributor
|
i’ll help take a look at this PR over the next couple days |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adds a post-write safety check to HashBasedShuffleWriter and SortBasedShuffleWriter: after the write loop completes, verify the input iterator was fully consumed. If records remain, kill the task with TaskKilledException. This guards against silent data loss.
Why are the changes needed?
It could give another layer of correctness guarantee.
Does this PR resolve a correctness bug?
Enhance correctness guarantee.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT