Conversation
|
Hi, I am interested in the work, that you are doing here. Question: I notice, that your patch provides changes in the native code. That makes me hesitant: Before I accept the PR, could you help me to setup a build environment, where I can test these changes. Background: We are considering a new release. As of now, there are no changes in the native code, so we could (in theory) just copy the native files from the previous release. But, for a release, that includes this PR, we would need a running build environment, where we can produce the updated files. If this is interesting to you, please contact me privately at jochen@apache.org. Thanks, Jochen |
|
We really need to update our GitHub build to deal with the C sources... |
|
We need to be able to tell GitHub builds that we need OpenSSL >= 1.1.1 |
|
I found a warning in Java CI / build (macos-latest, 8, false): Maybe the OpenSSL in Github builds is 1.0.0 |
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
sebbASF
left a comment
There was a problem hiding this comment.
Changes look fine; however there are no tests
add sm4-ctr and sm4-cbc in opensslCipher