Conversation
peek() returned false early only when length was smaller than the number of buffered bytes. A larger length fell through to the comparison loop, which read past the valid bytes into the backing array, so a buffer holding two bytes reported an exact match for a four-byte pattern. Return false unless length equals the buffered count.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CircularByteBuffer.peek()returned false early only whenlengthwas smaller than the number of buffered bytes. A largerlengthfell through to the comparison loop, which read past the valid bytes into whatever the backing array held there, so a fresh buffer holding{1, 2}reported an exact match for{1, 2, 0, 0}. ThroughPeekableInputStream.peek()a two-byte stream matched a four-byte pattern, and a scanner branching on that result took the branch for content the stream does not contain.The guard now returns false unless
lengthequals the buffered count, the exact-match rule IO-855 documented.Tests:
testPeekLongerThanBufferedandtestPeekLongerThanInputDoesNotMatch, red on master and green with the change. Default Maven goal green.mvn; that'smvnon the command line by itself.