Conversation
Keep the eager prefix buffer aligned with the delegate when reset returns to its initial position. Preserve buffered replay for explicit marks and cover repeated resets with and without an included BOM. Exclude the fbIndex synchronization heuristic for this documented non-thread-safe class without changing its locking contract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes IO-893.
BOMInputStreameagerly buffers the first bytes in its constructor. Resetting aByteArrayInputStreambefore an explicitmark()rewinds the delegate to zero, but previously replayed the old buffer as well, duplicating the prefix and potentially including an excluded BOM.Rebuild the initial buffer after an implicit reset and preserve the existing buffered-position behavior for explicit marks. Tests cover BOM inclusion/exclusion, no BOM, short input, and repeated resets. A field-specific SpotBugs exclusion reflects the class's documented lack of thread safety.
Validation: default
mvnon JDK 21 passed (6,621 tests, 33 skipped), including RAT, API compatibility, Checkstyle, SpotBugs, PMD and Javadoc. All five new regression cases fail without the fix.mvn; that'smvnon the command line by itself.