Fix RFC 9068 compliance: set typ header to at+jwt for JWT access tokens#2948
Open
Fix RFC 9068 compliance: set typ header to at+jwt for JWT access tokens#2948
Conversation
Per RFC 9068 Section 2.1, JWT access tokens MUST include a typ header parameter set to "at+jwt". This change: - Adds TYPE_AT_JWT constant to JoseConstants - Adds AT_JWT member to JoseType enum with proper lookup - Sets the at+jwt type on both JWS and JWE headers when producing JWT access tokens in AbstractOAuthDataProvider Closes #990 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
|
@coheigea could you please help me to validate this pull request? I will also take a look, thank you |
gnodet
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CXF supports JWT-formatted access tokens via
useJwtFormatForAccessTokens, but the produced tokens are missing thetyp: at+jwtheader required by RFC 9068 Section 2.1:Without this header, any RFC 9068-compliant resource server would reject CXF-issued JWT access tokens. This is a spec compliance bug.
Changes
JoseConstants: AddedTYPE_AT_JWT = "at+jwt"constantJoseType: AddedAT_JWTenum member with propergetType()lookup (sinceat+jwtcan't be a Java identifier, it needs explicit handling likeJOSE_JSON)AbstractOAuthDataProvider.processJwtAccessToken(): Sets theat+jwttype on both JWS and JWE headers, handling both the sign-only and sign+encrypt cases per RFC 9068 Section 2.1 and Section 4This is a proper implementation incorporating @reta's review feedback from #990 (using the type system properly and handling both JWS and JWE).
Closes #990
Test plan
JwsCompactReaderWriterTest— passesOAuth2JwtFiltersTest— 5 tests passJAXRSOAuth2TlsTest— 5 tests pass🤖 Generated with Claude Code