Apply recursion limit without std - #2465
Merged
Merged
Conversation
LucaCappelletti94
marked this pull request as ready for review
August 30, 2026 08:51
Contributor
Author
|
@alamb since this version would be the first one fully support no-std, I would suggest we merge this one last no-std-related fix before the release |
alamb
reviewed
Aug 31, 2026
| uses: ./.github/actions/setup-builder | ||
| with: | ||
| targets: 'thumbv6m-none-eabi' | ||
| - run: cargo test --release --no-default-features --test no_std_recursion |
|
|
||
| use super::ParserError; | ||
|
|
||
| /// Tracks remaining recursion depth. This value is decremented on |
Contributor
There was a problem hiding this comment.
why remove all these comments?
6 tasks
alamb
approved these changes
Sep 3, 2026
alamb
left a comment
alamb
left a comment
Contributor
There was a problem hiding this comment.
Thank you @LucaCappelletti94
I took the liberty of merging up from main and touching up some comments
iffyio
approved these changes
Sep 3, 2026
iffyio
left a comment
iffyio
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks @LucaCappelletti94!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parser::with_recursion_limitdocumented a hard parser depth limit, but builds withoutstdused a stubRecursionCounterthat always succeeded. Deeply nested input could overflow the stack instead of returningParserError::RecursionLimitExceeded.This makes the counter use
alloc::rc::Rcandcore::cell::Cell, which are available withoutstd, and adds a--no default-featuresruntime test to the no-std CI path.