-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat(aggregate): cost-aware partial-aggregation skip (opt-in) #22518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
zhuqi-lucas
wants to merge
20
commits into
apache:main
Choose a base branch
from
zhuqi-lucas:feat/adaptive-partial-agg-cost
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+619
−45
Draft
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
88f6d4c
feat(aggregate): cost-aware partial-aggregation skip (opt-in)
zhuqi-lucas 9940d8a
[FOR BENCHMARK ONLY] flip default to true + update SLT
zhuqi-lucas 2b49798
tune: drop cost_ns_per_row default from 1000 → 100
zhuqi-lucas 5c10375
Merge branch 'main' into feat/adaptive-partial-agg-cost
zhuqi-lucas e6a98fe
pivot to lower-ratio Rule 2 + diagnostic gauges
zhuqi-lucas c087cb4
revert benchmark-only default flip; default back to false
zhuqi-lucas 3cbcdfa
feat: A/B sampling for cost-aware partial-agg skip decision
zhuqi-lucas acb2ad9
[FOR BENCHMARK ONLY] flip default to true so bot exercises A/B sampling
zhuqi-lucas df6e264
ci: re-trigger after GitHub Actions infra outage
zhuqi-lucas 44f815a
feat: segment-level re-probing for dynamic distribution shifts
zhuqi-lucas c716f33
Merge branch 'main' into feat/adaptive-partial-agg-cost
zhuqi-lucas a258afe
Revert "feat: segment-level re-probing for dynamic distribution shifts"
zhuqi-lucas a2baa6c
test: explicitly disable cost model in legacy not-locked-until-skip test
zhuqi-lucas 08215ab
test: regen push_down_filter_parquet.slt for new probe gauges
zhuqi-lucas 62c2580
lazy-register diagnostic gauges so small queries don't show '...=0' n…
zhuqi-lucas ffbf659
Merge branch 'main' into feat/adaptive-partial-agg-cost
zhuqi-lucas 81493aa
test: disable cost model in push_down_filter_regression to stabilise …
zhuqi-lucas d1f8b7b
Merge branch 'main' into feat/adaptive-partial-agg-cost
zhuqi-lucas 6f3d9c7
Merge branch 'main' into feat/adaptive-partial-agg-cost
zhuqi-lucas 3120c71
fix: flush elapsed_compute timer before probe reads value, refresh docs
zhuqi-lucas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the observation here that the hard coded lmits / heuristics we built into the probe decision don't always work in real world situations and thus an actual runtime decision is better?