Revert "vars.USE_RUNS_ON"#22923
Draft
blaginin wants to merge 1 commit into
Draft
Conversation
This reverts commit e62f06c.
github-actions
Bot
added
the
development-process
Member
Author
|
btw, apache/datafusion branches (e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@gmcdonald has rolled back the runs-on app so we can get faster CI back, and also reduce the burden on GitHub Actions: #22455
I was hoping to just switch the
USE_RUNS_ONflag in the settings, but it turns out forks have no access to upstream env variables, even if they are not secrets.That means if runs-on is ever disabled again, we'll need to revert the revert... Or maybe we can have a check at the beginning of each CI run that reads some config flag / checks whether runs-on is available, and decides where to schedule the rest.
I don't mind doing either. Curious what others think? Maybe an auto CI check to make this more automated? Happy to do that on top.