Skip to content

ci: Setup valid Cargo.lock for depcheck to unblock CI#22933

Open
AdamGS wants to merge 2 commits into
apache:mainfrom
AdamGS:adamg/fix-depcheck-dep-issue
Open

ci: Setup valid Cargo.lock for depcheck to unblock CI#22933
AdamGS wants to merge 2 commits into
apache:mainfrom
AdamGS:adamg/fix-depcheck-dep-issue

Conversation

@AdamGS

@AdamGS AdamGS commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

depcheck stopped working because an underlying dependency released a non-semver compatible change (time 0.3.48, not going to link to the issue there because people are already spamming it). Because there was no lockfile, every run pulled the most recent versions for all dependencies, which don't currently compile.

What changes are included in this PR?

  1. Add lockfile to depcheck
  2. Make sure to run depcheck with --lock in CI

Are these changes tested?

Tested locally

Are there any user-facing changes?

None

@github-actions github-actions Bot added the development-process Related to development process of DataFusion label Jun 12, 2026
@AdamGS

AdamGS commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

I can't seem to reproduce the license check failure, I've tried to reproduce a clear hawkeye install on my laptop but nothing fails. The security audit seems unrelated and is also not blocking.

@AdamGS AdamGS changed the title ci: Setup valid Cargo.lock for depcheck ci: Setup valid Cargo.lock for depcheck to unblock CI Jun 12, 2026
@AdamGS AdamGS changed the title ci: Setup valid Cargo.lock for depcheck to unblock CI ci: Setup valid Cargo.lock for depcheck to unblock CI Jun 12, 2026
@AdamGS

AdamGS commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

just realized it just says in the log that's its an HTTP error, just need someone to retry it.

@blaginin blaginin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@blaginin

Copy link
Copy Markdown
Member

I'll retry

@Jefffrey Jefffrey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea; though looks like theres new CVEs? 🙁

@AdamGS

AdamGS commented Jun 13, 2026

Copy link
Copy Markdown
Contributor Author

@Jefffrey addressed that in #22937

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of DataFusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dependency checker fails to build

3 participants