Remove orphaned snowflake_flatten_validation.sql script#22938
Open
AdamGS wants to merge 1 commit into
Open
Conversation
Signed-off-by: Adam Gutglick <adamgsal@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This file seems to be a leftover of #21593. I see what its trying to do, but most developers don't have access to a Snowflake instance, and the transformations are already all coded in tests.
I looked into turning it into some sort of SLT tests, but I couldn't find a Snowflake-provided mock server.
What changes are included in this PR?
snowflake_flatten_validation.sqlAre these changes tested?
Existing tests. I ran all the tests in
datafusion-sqlto make sure there's no hidden dependency I missed.Are there any user-facing changes?
None