feat: Allow datafusion-ffi to opt out of proto parquet#22951
Open
Xuanwo wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
datafusion-ffiinheritsdatafusion-protofrom the workspace. Becausedatafusion-protoenables itsparquetfeature by default, downstream crates that depend ondatafusion-ffialso pull indatafusion-datasource-parquet,parquet, and parquet compression dependencies even when they do not need parquet-aware proto support.Cargo features are additive, so downstream users cannot opt out by disabling default features on their own direct
datafusion-protodependency if thedatafusion-ffi -> datafusion-protoedge has already enabled defaults.What changes are included in this PR?
This PR makes the workspace
datafusion-protodependency default todefault-features = false, then lets crates opt into the previous behavior explicitly.For
datafusion-ffi, the previous default behavior is preserved with a new defaultparquetfeature. Downstream users that want to avoid parquet dependencies can now usedatafusion-ffiwithdefault-features = false.The FFI session table option bridge now gates
ConfigFileType::PARQUETusage behind thedatafusion-ffi/parquetfeature, while still preserving parquet table option values in no-default builds.Are these changes tested?
Yes. Existing
datafusion-ffitests pass with default features and with--no-default-features. The feature graph was also checked to confirm that defaultdatafusion-ffistill enables parquet, whiledatafusion-ffi --no-default-featuresdoes not includedatafusion-datasource-parquet.Are there any user-facing changes?
Default behavior is unchanged. Users can now opt out of parquet-aware proto support from
datafusion-ffiby disablingdatafusion-ffidefault features.