fix: validate parquet statistics config - #24642
Open
zhangxinyao88 wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
sqllogictest
zhangxinyao88
force-pushed
the
codex/datafusion-17498-statistics-validation
branch
from
August 24, 2026 23:54
7192caa to
99c04f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
datafusion.execution.parquet.statistics_enabledaccepts arbitrary strings. Invalid values silently fall back to the Parquet writer default instead of failing when set.What changes are included in this PR?
This adds a typed config enum for
none,chunk, andpage. It validates values at config and protobuf boundaries and passes the validated value to the Parquet writer.Are these changes tested?
Yes. Unit, protobuf round-trip, and SQL logic tests were added. The full lint and extended workspace test suites pass.
Are there any user-facing changes?
Invalid values now fail at
SETtime. Valid values remain case-insensitive and are displayed in lowercase.This changes
ParquetOptions.statistics_enabledfromOption<String>toOption<DFParquetStatistics>, so the PR may need theapi changelabel.