Skip to content

tests: Add IN list coverage for FixedSizeBinary - #24660

Merged
alamb merged 1 commit into
apache:mainfrom
alamb:alamb/in_lists_fsb
Aug 25, 2026
Merged

tests: Add IN list coverage for FixedSizeBinary#24660
alamb merged 1 commit into
apache:mainfrom
alamb:alamb/in_lists_fsb

Conversation

@alamb

@alamb alamb commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

I want full end to end coverage of IN lists and their optimizations as sqllogictests, not just unit tests

What changes are included in this PR?

  1. Add SLT coverage for FixedSizeBinary arrays (to cover the specializations added in IN LIST: reuse primitive filters for FixedSizeBinary #24102)

Are these changes tested?

They are only tests

Are there any user-facing changes?

No, tests only

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.44%. Comparing base (163b909) to head (cd73517).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #24660      +/-   ##
==========================================
- Coverage   81.44%   81.44%   -0.01%     
==========================================
  Files        1118     1118              
  Lines      399560   399560              
  Branches   399560   399560              
==========================================
- Hits       325424   325421       -3     
  Misses      55138    55138              
- Partials    18998    19001       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alamb
alamb added this pull request to the merge queue Aug 25, 2026
@alamb

alamb commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

Thank you @xudong963 -- since these are just tests I will merge them in without waiting for 24 hours

Merged via the queue into apache:main with commit 63f5b55 Aug 25, 2026
38 checks passed
@alamb
alamb deleted the alamb/in_lists_fsb branch August 25, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants