Skip to content

Check for overflows in left dataset concat in hash join - #24671

Draft
shivbhatia10 wants to merge 2 commits into
apache:mainfrom
shivbhatia10:sb/hash-join-handle-concat-overflow
Draft

Check for overflows in left dataset concat in hash join#24671
shivbhatia10 wants to merge 2 commits into
apache:mainfrom
shivbhatia10:sb/hash-join-handle-concat-overflow

Conversation

@shivbhatia10

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

  • Closes #.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions Bot added the physical-plan Changes to the physical-plan crate label Aug 25, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.46288% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.44%. Comparing base (63f5b55) to head (548bf6b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...tafusion/physical-plan/src/joins/hash_join/exec.rs 85.79% 11 Missing and 13 partials ⚠️
datafusion/physical-plan/src/joins/utils.rs 90.00% 3 Missing and 2 partials ⚠️
...fusion/physical-plan/src/joins/hash_join/stream.rs 80.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #24671    +/-   ##
========================================
  Coverage   81.44%   81.44%            
========================================
  Files        1118     1118            
  Lines      399550   399818   +268     
  Branches   399550   399818   +268     
========================================
+ Hits       325398   325638   +240     
- Misses      55154    55165    +11     
- Partials    18998    19015    +17     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

physical-plan Changes to the physical-plan crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants