feat: support dictionary in approx_distinct - #24731
Closed
Rich-T-kid wants to merge 2 commits into
Closed
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24731 +/- ##
========================================
Coverage 81.44% 81.45%
========================================
Files 1120 1120
Lines 401605 401817 +212
Branches 401605 401817 +212
========================================
+ Hits 327098 327282 +184
- Misses 55348 55359 +11
- Partials 19159 19176 +17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Thanks @Rich-T-kid, but it appears @mkleen already has a PR to add this at #24646. Maybe you could help review that PR. |
Contributor
Author
@nuno-faria thanks for letting me know |
Contributor
Author
|
closing in favor of https://github.com/apache/datafusion/pull/24646/changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
see #24730
What changes are included in this PR?
Two lines of change in
approx_distinct.rs:DataType::Dictionary(_, _)=>Box::new(HLLAccumulator::new())arm in accumulator()DataType::Dictionary(_, _)to the is_hll_groups_type matchAre these changes tested?
yes, 1 test was added.
Are there any user-facing changes?
yes,
approx-distinct(dictionary)will no longer panic.