Repository navigation
fix: apply spill_compression to RepartitionExec spill files - #26142
Merged
Merged
Conversation
Contributor
Author
|
@jayzhan211 could you take a look? thanks! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26142 +/- ##
==========================================
- Coverage 82.75% 82.75% -0.01%
==========================================
Files 1147 1147
Lines 449841 449900 +59
Branches 449841 449900 +59
==========================================
+ Hits 372253 372294 +41
- Misses 54912 54921 +9
- Partials 22676 22685 +9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jayzhan211
approved these changes
Oct 9, 2026
jayzhan211
left a comment
Contributor
There was a problem hiding this comment.
Thanks @adriangb , LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
RepartitionExecignoresdatafusion.execution.spill_compressionand always spills uncompressed #26141.Rationale for this change
RepartitionExecdoes not applydatafusion.execution.spill_compression, so its spill files are always uncompressed. All other spilling operators (sort, aggregate, sort-merge join, nested loop join) apply the setting. A user who sets a codec to decrease spill disk usage gets no decrease for the data thatRepartitionExecspills.What changes are included in this PR?
RepartitionExec::executenow builds itsSpillManagerwith.with_compression_type(context.session_config().spill_compression()), the same as the other operators.SpillManager::newcall sites.RepartitionExecwas the only one that did not pass the setting.What is the testing strategy for this PR?
The new test
repartition_spill_honors_spill_compressionruns a spillingRepartitionExecon constant (highly compressible) data withuncompressed,lz4_frameandzstd. It asserts that the same rows spill, that the data reads back intact, and thatspilled_byteswith a codec is less than half of the uncompressed value.The test fails on
main(679264 vs 679264 bytes) and passes with the fix:spill_compressionspilled_bytesonmainspilled_byteswith this PRuncompressedlz4_framezstdAre there any user-facing changes?
Yes. Spill files from
RepartitionExecnow use the codec fromdatafusion.execution.spill_compression. The default (uncompressed) does not change. There are no API changes.