Repository navigation
WIP speed up hashes (Primitive) - #26143
Rich-T-kid wants to merge 3 commits into
Conversation
|
show benchmark queue |
|
Hi @Rich-T-kid, you asked to view the benchmark queue (#26143 (comment)).
File an issue against this benchmark runner |
|
run benchmarks |
|
run benchmark with_hashes |
|
run benchmark clickbench |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing rich-T-kid/faster-hash-writes (5f5951c) to 409e3b8 (merge-base) diff Run configurationrun benchmark clickbench_partitionedResults will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing rich-T-kid/faster-hash-writes (5f5951c) to 409e3b8 (merge-base) diff Run configurationrun benchmark with_hashesResults will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing rich-T-kid/faster-hash-writes (5f5951c) to 409e3b8 (merge-base) diff Run configurationrun benchmark tpcdsResults will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing rich-T-kid/faster-hash-writes (5f5951c) to 409e3b8 (merge-base) diff Run configurationrun benchmark tpcdsCPU Details (lscpu)Details
Resource Usagetpcds — base (merge-base)
tpcds — branch
File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing rich-T-kid/faster-hash-writes (5f5951c) to 409e3b8 (merge-base) diff Run configurationrun benchmark clickbenchResults will be posted here when complete File an issue against this benchmark runner |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26143 +/- ##
========================================
Coverage 82.75% 82.75%
========================================
Files 1147 1147
Lines 449886 450007 +121
Branches 449886 450007 +121
========================================
+ Hits 372303 372419 +116
- Misses 54911 54914 +3
- Partials 22672 22674 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing rich-T-kid/faster-hash-writes (5f5951c) to 409e3b8 (merge-base) diff Run configurationrun benchmark tpchResults will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing rich-T-kid/faster-hash-writes (5f5951c) to 409e3b8 (merge-base) diff Run configurationrun benchmark clickbench_partitionedCPU Details (lscpu)Details
Resource Usageclickbench_partitioned — base (merge-base)
clickbench_partitioned — branch
File an issue against this benchmark runner |
|
Benchmark for this request failed before finishing (Kubernetes reason: Benchmarks requested: Runner log (last 40 lines)Kubernetes messageFile an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing rich-T-kid/faster-hash-writes (5f5951c) to 409e3b8 (merge-base) diff Run configurationrun benchmark tpchCPU Details (lscpu)Details
Resource Usagetpch — base (merge-base)
tpch — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing rich-T-kid/faster-hash-writes (5f5951c) to 409e3b8 (merge-base) diff Run configurationrun benchmark with_hashesCPU Details (lscpu)Details
Resource Usagewith_hashes — base (merge-base)
with_hashes — branch
File an issue against this benchmark runner |
|
run benchmark with_hashes |
1 similar comment
|
run benchmark with_hashes |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing rich-T-kid/faster-hash-writes (b0dff4a) to 409e3b8 (merge-base) diff Run configurationrun benchmark with_hashes
env:
BENCH_FILTER: "int"Results will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing rich-T-kid/faster-hash-writes (b0dff4a) to 409e3b8 (merge-base) diff Run configurationrun benchmark with_hashes
env:
BENCH_FILTER: "int"Results will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing rich-T-kid/faster-hash-writes (b0dff4a) to 409e3b8 (merge-base) diff Run configurationrun benchmark with_hashes
env:
BENCH_FILTER: "int"CPU Details (lscpu)Details
Resource Usagewith_hashes — base (merge-base)
with_hashes — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing rich-T-kid/faster-hash-writes (b0dff4a) to 409e3b8 (merge-base) diff Run configurationrun benchmark with_hashes
env:
BENCH_FILTER: "int"CPU Details (lscpu)Details
Resource Usagewith_hashes — base (merge-base)
with_hashes — branch
File an issue against this benchmark runner |
Splits the single scalar loop in `hash_array_primitive`'s no-null branch
into two const-generic-free helpers that batch independent hashes so the
pipeline isn't serialized on store-to-load deps:
- `hash_prim_fresh_dense`: overwrite mode, 16 rows per iteration.
- `hash_prim_rehash_dense`: fold-with-prev mode, 8 rows per iteration
(narrower because each lane holds both `prev` and `value` live).
Both use `get_unchecked` / `get_unchecked_mut` with proven invariants
(hashes.len() == values.len()) and a scalar tail for the remainder.
Benchmarks (int64, 8192 rows, no nulls) on Apple M4 Max:
single, no nulls : neutral to small regression (<+7%)
multiple, no nulls : ~-14%
The nullable path is unchanged -- see PR apache#26143 for the sibling change.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
What is the testing strategy for this PR?
Are there any user-facing changes?