Skip to content

[fix](be) explicitly close stream load recorder RocksDB on shutdown#63004

Open
sollhui wants to merge 1 commit intoapache:masterfrom
sollhui:fix_stream_load_recorder_shutdown
Open

[fix](be) explicitly close stream load recorder RocksDB on shutdown#63004
sollhui wants to merge 1 commit intoapache:masterfrom
sollhui:fix_stream_load_recorder_shutdown

Conversation

@sollhui
Copy link
Copy Markdown
Contributor

@sollhui sollhui commented May 6, 2026

What problem does this PR solve?

Problem Summary:

Explicitly close the RocksDB instance used by StreamLoadRecorder during destruction.

Previously, StreamLoadRecorder::~StreamLoadRecorder() only destroyed column family handles and synced WAL, then relied on DBWithTTL destruction to close RocksDB implicitly. If BE failed during startup, for example because be_port was already occupied, shutdown cleanup could enter RocksDB DBImpl::CloseHelper() from the implicit destructor path and crash while unscheduling background work.

This patch makes the shutdown sequence explicit:

  • Sync WAL before closing
  • Cancel RocksDB background work and wait for completion
  • Destroy column family handles
  • Close the DB explicitly
  • Reset the DB pointer after close

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants