branch-4.0: [fix](cast) Handle DST fallback in timestamp cast monotonicity #65903 - #66185
Open
github-actions[bot] wants to merge 1 commit into
Open
branch-4.0: [fix](cast) Handle DST fallback in timestamp cast monotonicity #65903#66185github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Related PR: #59399 Problem Summary: A TIMESTAMPTZ range-partitioned scan could lose rows when a runtime filter or static predicate targeted `CAST(part_col AS DATETIMEV2)` in a session timezone that crosses a daylight-saving fall-back transition. The monotonicity check treated all date-like casts as unconditionally monotonic. Pruning then folded both partition endpoints; at the fall-back boundary the projected local time moved backward, producing an invalid range and pruning a partition that contained a matching value. Make TIMESTAMPTZ-to-DATETIMEV2 monotonicity range-aware. Fixed-offset zones remain monotonic. For dynamic zones, partitions with finite bounds remain eligible only when `(lower, upper]` contains no fall-back transition; unbounded ranges conservatively skip the monotonic shortcut. Scale-reducing casts in dynamic zones also conservatively skip the shortcut because UTC rounding can cross a fall-back transition just outside the original bounds. Add unit coverage and a regression covering runtime-filter and static partition pruning. ### Release note Fix incorrect partition pruning for TIMESTAMPTZ-to-DATETIMEV2 casts across daylight-saving fall-back transitions.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #65903