Skip to content

[Fix](udf) strip file name when http url has query string #66193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liutang123 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Fix](udf) strip file name when http url has query string #66193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions be/src/runtime/user_function_cache.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,6 +463,14 @@ std::string UserFunctionCache::_get_file_name_from_url(const std::string& url) c
} else {
file_name = url;
}
// Strip the query string (e.g. the "?q-sign-algorithm=..." of a COS/S3
// presigned URL). Otherwise it would be treated as part of the file name,
// which may exceed the filesystem NAME_MAX (255 bytes) limit and cause
// fopen to fail with ENAMETOOLONG.
size_t query_pos = file_name.find('?');
if (query_pos != std::string::npos) {
file_name = file_name.substr(0, query_pos);
}
return file_name;
}

Expand Down
Loading