DRILL-8180: Add Icons to Storage Plugin List#2507
DRILL-8180: Add Icons to Storage Plugin List#2507cgivre wants to merge 3 commits intoapache:masterfrom
Conversation
|
Nice touch. I see we don't always have transparent backgrounds and sometimes we have a visible block behind the rendered icon. Let me know if I can help out here by hitting them with the GIMP. |
I would really appreciate that. I don't actually have image editing software on my machine, or experience with the GIMP. Also, if you don't like any of the icons, feel free to change. |
vvysotskyi
left a comment
There was a problem hiding this comment.
Is it possible to add plugin pictures to specific storage plugin folders instead of adding it to the java-exec module?
I suppose so, but I'm not quite sure how you would do that. All the Drill REST server components (to include static resources) are contained in |
|
When running java application, resources from all places that are in class path should be accessible. |
b5f2c24 to
0a208c0
Compare
DRILL-8180: Add Icons to Storage Plugin List
Description
Documentation
This PR adds icons to the storage plugin list depending on the type of storage plugin. See screenshot below.
The logo gets its name from the plugin config file. So a plugin
FooStoragePluginConfigwould be required to provide an icon of approx 40px x 40px calledFoo.png.Testing
Tested manually