[ISSUE apache/dubbo#13862] Migrate dubbo-samples-triple-rest-openapi-generator to Spring Boot 3.2.3 - #1301
Open
zengbohan1 wants to merge 2 commits into
Open
Conversation
…2.3 (#13862) - Bump spring-boot-starter-parent from 2.7.18 to 3.2.3, aligning the module with the dubbo-samples-triple-rest aggregate parent BOM; this was the last sample still on Spring Boot 2.x - Replace javax.annotation-api with jakarta.annotation-api and migrate the generated sources to jakarta.annotation.Generated - Enable useJakartaEe in the openapi-generator config so regenerated sources stay on the jakarta namespace - Update README system requirements to Java 17+ Verified with 'mvn clean package -DskipTests' (same as CI build opts): build succeeds on Spring Boot 3.2.3 / JDK 17.
Previous run failed on unrelated infra issues: - build-samples: Maven Central returned 502 while resolving spring-boot-starter-aop:2.3.12.RELEASE for dubbo-samples-spring-boot-hystrix - Integration Test (Java21, Job5): dubbo-samples-triple-rest-spring-security build failure against dubbo.version=3.3.7-SNAPSHOT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the last remaining Spring Boot 2 sample to Boot 3, as tracked in apache/dubbo#13862 (claim comment: apache/dubbo#13862 (comment)).
Changes
spring-boot-starter-parentfrom 2.7.18 to 3.2.3 indubbo-samples-triple-rest-openapi-generator, aligning the module with thedubbo-samples-triple-restaggregate parent BOM — this was the last sample in the repository still on Spring Boot 2.xjavax.annotation-apiwithjakarta.annotation-apiand migrate the generated sources fromjavax.annotation.Generatedtojakarta.annotation.GenerateduseJakartaEein thepom-generator.xmlopenapi-generator config (7.16.0 supports it) so future regenerations stay on the jakarta namespaceVerification
mvn clean package -DskipTestssucceeds on JDK 17 (same command as the CI build opts, which also test againstspring-boot.version:3.2.3)javaximports remain undersrc/Notes
contextLoadstest requires a running Zookeeper and is skipped by CI's-DskipTestsbuild opts, so it is not affected by this change.