Skip to content

FINERACT-2734: Upgrade to JDK 25 LTS - #6222

Open
IOhacker wants to merge 2 commits into
apache:developfrom
FintecheandoMX:develop
Open

FINERACT-2734: Upgrade to JDK 25 LTS#6222
IOhacker wants to merge 2 commits into
apache:developfrom
FintecheandoMX:develop

Conversation

@IOhacker

@IOhacker IOhacker commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Description

FINERACT-2734: Upgrade to JDK 25 LTS

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.
  • If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@IOhacker
IOhacker requested review from Aman-Mittal, adamsaghy, meonkeys and vidakovic and removed request for adamsaghy August 3, 2026 17:00
Aman-Mittal
Aman-Mittal previously approved these changes Aug 4, 2026

@Aman-Mittal Aman-Mittal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for me @meonkeys @adamsaghy @vidakovic

FYI.

Changes are minimal compared to dependency bump. and also discussed in dev list.

@Aman-Mittal Aman-Mittal added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code java Pull requests that update Java code gradle labels Aug 4, 2026
@meonkeys

meonkeys commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

There are a few more places under fineract-doc/ to update. egrep -ri 'java.+ 21' fineract-doc/src lists these three:

  1. fineract-doc/src/docs/en/chapters/development/index.adoc
  2. fineract-doc/src/docs/en/chapters/testing/cucumber.adoc
  3. fineract-doc/src/docs/en/chapters/testing/integration.adoc

The 1st should be updated, and the 2nd and 3rd ones should be changed to reference (not duplicate) the first, like we do in the readme. One source of truth FTW.

@meonkeys meonkeys left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few more places under fineract-doc/ to update.

Here's the patch. I can't push directly to the branch so you'll have to apply it yourself (assuming you want it).

0001-update-asciidoc.patch

Apply it locally with git am. No need to squash.

@IOhacker

IOhacker commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

@meonkeys let me try

@Aman-Mittal

Copy link
Copy Markdown
Member

Should i create a Dedicated Branch for this so that any committer can rebase against develop?

@meonkeys

meonkeys commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Should i create a Dedicated Branch for this so that any committer can rebase against develop?

No, just wait. @IOhacker said he'd apply the patch himself.

@IOhacker

IOhacker commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

@meonkeys @Aman-Mittal for your review

FINERACT-2734: Upgrade to JDK 25 LTS

@meonkeys meonkeys left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code gradle java Pull requests that update Java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants