[FLINK-40561][changelog] Migrate flink-statebackend-changelog tests to JUnit 5 and AssertJ - #29113
Open
Alwaysgaurav1 wants to merge 1 commit into
Open
Conversation
…o JUnit 5 and AssertJ
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Under parent umbrella FLINK-25325 and issue FLINK-40561, this pull request modernizes all remaining JUnit 4 and Hamcrest test classes in the
flink-statebackend-changelogmodule to JUnit 5 (Jupiter) and AssertJ.Brief change log
@Test,@BeforeEach,@AfterEach,@TempDir) and package-private visibility.ChangelogDelegateStateTest,ChangelogKeyedStateBackendTest) to Flink's@ExtendWith(ParameterizedTestExtension.class)and@TestTemplate.@Rule TemporaryFolderto Jupiter's@TempDir Path.@Test(expected = ...)with AssertJ'sassertThatThrownBy(...).org.junit.Assert.*and Hamcrest matchers (containsInAnyOrder, etc.) to fluent AssertJassertThat(...)assertions.ChangelogMetricGroupTestChangelogStateBackendLoadingTestChangelogStateDiscardTestChangelogListStateTestChangelogMapStateTestChangelogPqStateTestStateChangeLoggerTestBaseKvStateChangeLoggerImplTestPriorityQueueStateChangeLoggerImplTestChangelogDelegateStateTestChangelogKeyedStateBackendTestChangelogStateBackendTestUtilsVerifying this change
This change is a test cleanup and refactoring with zero production code changes.
mvn test -pl flink-state-backends/flink-statebackend-changelog: 668 tests executed, 0 failures, 0 errors, 31 skipped).mvn checkstyle:check -pl flink-state-backends/flink-statebackend-changelog).Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation