[FLINK-40568][tests] Fix flaky ProcessTableFunctionSemanticTests by using materialized data assertion - #29117
Open
spuru9 wants to merge 1 commit into
Open
[FLINK-40568][tests] Fix flaky ProcessTableFunctionSemanticTests by using materialized data assertion#29117spuru9 wants to merge 1 commit into
spuru9 wants to merge 1 commit into
Conversation
…sing materialized data assertion The process-updating-multi-input program runs the two-input updating PTF join UpdatingJoinFunction and asserted the sink's raw changelog. A two-input operator interleaves its two inputs nondeterministically, so the emitted changelog is not fixed and the pinned expectation failed intermittently in CI. Assert the materialized upsert result via SinkTestStep#testMaterializedData() instead, which converges regardless of cross-input arrival order. This mirrors FLINK-39729 and the multi-input join test programs. Generated-by: Claude Code (claude-opus-4-8)
Collaborator
spuru9
marked this pull request as draft
September 10, 2026 16:32
spuru9
marked this pull request as ready for review
September 10, 2026 16:32
Contributor
Author
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fixes the flaky
ProcessTableFunctionSemanticTestsfor theprocess-updating-multi-inputprogram, which intermittently fails in CI with an output mismatch:The program runs the two-input updating PTF join
UpdatingJoinFunctionand asserts the sink's raw changelog. A two-input operator interleaves its two inputs nondeterministically, so the emitted changelog is not fixed — the test pinned one interleaving, and an alternate order fails the assertion. The final materialized (upsert) result is the same either way.Brief change log
process-updating-multi-inputviaSinkTestStep#testMaterializedData()instead of the raw changelog, mirroring FLINK-39729 (PR [FLINK-39729][table] Fix flaky CorrelateRestoreTest by using materialized data assertion #28224) and the multi-input join programs (MultiJoinTestPrograms).Test-only change; no production code is touched.
Verifying this change
The job is awaited to completion, then the sink result is checked. The materialized upsert result is order-independent (Bob →
score 2 in city Berlin, Alice deleted), so it no longer depends on cross-input arrival order.ProcessTableFunctionSemanticTests(72 cases) passed a repeated local loop on the same commit that failed in CI (JDK 17), with theprocess-updating-multi-inputcase green every time.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
AI usage disclosure