[spark] Add sparksql alter table partial support for set/remove table properties#2437
[spark] Add sparksql alter table partial support for set/remove table properties#2437wuchong merged 4 commits intoapache:mainfrom
Conversation
|
flink ut failed with |
fluss-spark/fluss-spark-common/src/main/scala/org/apache/fluss/spark/SparkCatalog.scala
Outdated
Show resolved
Hide resolved
fluss-spark/fluss-spark-common/src/main/scala/org/apache/fluss/spark/SparkCatalog.scala
Outdated
Show resolved
Hide resolved
| checkAnswer(sql("SHOW DATABASES"), Row(DEFAULT_DATABASE) :: Nil) | ||
| } | ||
|
|
||
| test("Catalog: set/remove table properties") { |
There was a problem hiding this comment.
Maybe it'll be nice to have a separate SparkTableChangeTest, which includes all Alter Table tests.
There was a problem hiding this comment.
above comments suggests add all DDL tests into one suite.
fluss-spark/fluss-spark-ut/src/test/scala/org/apache/fluss/spark/SparkCatalogTest.scala
Outdated
Show resolved
Hide resolved
fluss-spark/fluss-spark-ut/src/test/scala/org/apache/fluss/spark/SparkCatalogTest.scala
Outdated
Show resolved
Hide resolved
|
@Yohahaha left some comments here, and I suggest to simplify this title to |
wuchong
left a comment
wuchong
left a comment
There was a problem hiding this comment.
Hi @Yohahaha, I agree with @YannByron's comments. Could you please update the pull request to address them?
| intercept[ExecutionException] { | ||
| sql( | ||
| s"ALTER TABLE t SET TBLPROPERTIES('${ConfigOptions.TABLE_DATALAKE_FORMAT.key()}' = 'paimon')") | ||
| }.getCause.shouldBe(a[InvalidAlterTableException]) |
There was a problem hiding this comment.
Actually, this can be supported. But you need to enable datalake feature on the cluster.
There was a problem hiding this comment.
thank you! I will test this behavior in lake catalog DDL pr.
3 participants
Purpose
Linked issue: close #xxx
Brief change log
As title.
Tests
Catalog: set/remove table propertiesinorg.apache.fluss.spark.SparkCatalogTestAPI and Format
Documentation