Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Fluss’ release/legal artifacts to address ASF licensing/notice compliance (issue #2697), including generating binary distribution LICENSE/NOTICE variants and moving non-Apache dependency listings out of NOTICE into LICENSE files.
Changes:
- Add release helper scripts to derive binary LICENSE/NOTICE by removing the Maven Wrapper section.
- Update
create_binary_release.shto emit derived LICENSE/NOTICE into the binary tarball. - Refresh multiple module
META-INF/NOTICEfiles to remove non-Apache dependency listings, and introduce correspondingMETA-INF/LICENSE(+ license texts underMETA-INF/licenses/) for bundled third-party components.
Reviewed changes
Copilot reviewed 24 out of 28 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/releasing/derive_binary_notice.sh | New script to generate binary NOTICE without Maven Wrapper notice block. |
| tools/releasing/derive_binary_license.sh | New script to generate binary LICENSE without mvnw references. |
| tools/releasing/create_binary_release.sh | Use derive scripts instead of copying root LICENSE/NOTICE into the binary bundle. |
| fluss-server/src/main/resources/META-INF/NOTICE | Remove MIT/BSD dependency listing section from NOTICE. |
| fluss-server/src/main/resources/META-INF/LICENSE | Add module LICENSE containing Apache License text + third-party license summary. |
| fluss-lake/fluss-lake-lance/src/main/resources/META-INF/NOTICE | Remove non-Apache dependency listing sections from NOTICE. |
| fluss-lake/fluss-lake-lance/src/main/resources/META-INF/LICENSE | Add module LICENSE with Apache License text + third-party license summary. |
| fluss-lake/fluss-lake-iceberg/src/main/resources/META-INF/NOTICE | Remove non-Apache dependency listing sections from NOTICE. |
| fluss-filesystems/fluss-fs-s3/src/main/resources/META-INF/licenses/LICENSE.stax2api | Add third-party license text for stax2-api. |
| fluss-filesystems/fluss-fs-s3/src/main/resources/META-INF/licenses/LICENSE.re2j | Add third-party license text for re2j. |
| fluss-filesystems/fluss-fs-s3/src/main/resources/META-INF/NOTICE | Remove non-Apache dependency listing sections from NOTICE. |
| fluss-filesystems/fluss-fs-s3/src/main/resources/META-INF/LICENSE | Add module LICENSE with Apache License text + third-party license summary. |
| fluss-filesystems/fluss-fs-oss/src/main/resources/META-INF/NOTICE | Remove non-Apache dependency listing sections from NOTICE. |
| fluss-filesystems/fluss-fs-oss/src/main/resources/META-INF/LICENSE | Add module LICENSE with Apache License text + third-party license summary. |
| fluss-filesystems/fluss-fs-obs/src/main/resources/META-INF/NOTICE | Remove non-Apache dependency listing sections from NOTICE. |
| fluss-filesystems/fluss-fs-obs/src/main/resources/META-INF/LICENSE | Add module LICENSE with Apache License text + third-party license summary. |
| fluss-filesystems/fluss-fs-hdfs/src/main/resources/META-INF/NOTICE | Remove non-Apache dependency listing sections from NOTICE. |
| fluss-filesystems/fluss-fs-hdfs/src/main/resources/META-INF/LICENSE | Add module LICENSE with Apache License text + third-party license summary. |
| fluss-filesystems/fluss-fs-hadoop-shaded/src/main/resources/META-INF/NOTICE | Remove non-Apache dependency listing sections from NOTICE. |
| fluss-filesystems/fluss-fs-hadoop-shaded/src/main/resources/META-INF/LICENSE | Add module LICENSE with Apache License text + third-party license summary. |
| fluss-filesystems/fluss-fs-gs/src/main/resources/META-INF/licenses/LICENSE.stax2api | Add third-party license text for stax2-api. |
| fluss-filesystems/fluss-fs-gs/src/main/resources/META-INF/licenses/LICENSE.re2j | Add third-party license text for re2j. |
| fluss-filesystems/fluss-fs-gs/src/main/resources/META-INF/NOTICE | Remove non-Apache dependency listing sections from NOTICE. |
| fluss-filesystems/fluss-fs-gs/src/main/resources/META-INF/LICENSE | Add module LICENSE with Apache License text + third-party license summary. |
| fluss-filesystems/fluss-fs-azure/src/main/resources/META-INF/NOTICE | Remove non-Apache dependency listing sections from NOTICE. |
| fluss-filesystems/fluss-fs-azure/src/main/resources/META-INF/LICENSE | Add module LICENSE with Apache License text + third-party license summary. |
| fluss-client/src/main/resources/META-INF/NOTICE | Remove MIT/BSD dependency listing sections from NOTICE. |
| fluss-client/src/main/resources/META-INF/LICENSE | Add module LICENSE with Apache License text + third-party license summary. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bb6abd5 to
d012346
Compare
Member
|
Proposed complete fix: #2703 |
Contributor
Author
|
@jbonofre Thank you very much!!! I'll close mine and revew yours. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #2697
LICENSE should be a bit updated. For instance, mvnw is not part/used in
the code of the distribution.
The licenses folder contains some confusing
files (for instance LICENSE-re2j and LICENSE.re2j, which one is relevant,
LICENSE.cddlv1.1 applies to which dependency ?, ...)
The NOTICE is not
fully correct: the NOTICE should include the NOTICE for Apache
dependencies. The list of BSD licensed dependencies (like jsch, paranamer,
...) should not be in the NOTICE, it should be in LICENSE.
Brief change log
1: remove mvnw from binary release
2: unify LICENSE-re2j and LICENSE.re2j
3: add a LICENSE file to list BSD(Non-Apache) licensed dependencies, remove the listed from NOTICE
After go through https://infra.apache.org/licensing-howto.html#permissive-deps, seem it recommand to keep NOTICE as simple as possible.
Tests
API and Format
Documentation