HADOOP-19387. Recover LocalDirAllocator after failed initialization - #8660
Open
arhxam wants to merge 1 commit into
Open
HADOOP-19387. Recover LocalDirAllocator after failed initialization#8660arhxam wants to merge 1 commit into
arhxam wants to merge 1 commit into
Conversation
|
🎊 +1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Fixes HADOOP-19387.
LocalDirAllocatorcurrently records a directory configuration as initialized even when every configured directory fails initialization. An interruption can therefore leave an empty directory context cached indefinitely: later calls see the unchanged configuration and never retry.This patch records
savedLocalDirsonly after at least one directory is successfully initialized. A subsequent call can then retry a transiently failed initialization. The regression test uses a one-shotDiskValidatorfailure to exercise the same empty-context path deterministically, without relying on process timing.This supersedes the stale, closed attempt in #7298 and updates the regression coverage to the current JUnit 5 test suite.
How was this patch tested?
On macOS with OpenJDK 17.0.20 and Maven Wrapper 3.9.15:
Before the production change, the new test fails on the second allocation with
DiskErrorException, confirming the regression.For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles? N/AAI Tooling
Contains content generated by Codex.
https://www.apache.org/legal/generative-tooling.html