POC for size and timeout based flush at SourceShipper #7591
+124
−183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
| } | ||
|
|
||
| private void flushStagedWal() { | ||
| source.getReplicationEndpoint().beforePersistingReplicationOffset(); |
Contributor
There was a problem hiding this comment.
What if persisting the WAL entries fails at the endpoint? In that case, we should throw an exception and fail here as well, since we cannot move forward until the entries are successfully persisted at the endpoint.
Apache9
reviewed
Jan 7, 2026
Contributor
Apache9
left a comment
Apache9
left a comment
There was a problem hiding this comment.
I suggest we implement the POC based on the current master code base, and then applied the continous backup code on top of it. Otherwise it is a bit difficult to figure out what is the real modification for implementing this mechanism and what is because we have already supported continuius backup...
| // Loop until we close down | ||
| while (isActive()) { | ||
| // check if flush needed for WAL backup, this is need for timeout based flush | ||
| if (shouldFlushStagedWal()) { |
Contributor
There was a problem hiding this comment.
The name is a bit confusing, which still assumes that the WAL entries we send to ReplicationEndpoint are 'staged'...
Just name it 'shouldPersistLogPosition'. And we already have a logPositionAndCleanOldLogs method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is followup POC of #7528
This is needed for continuous backup and PITR feature: https://github.com/apache/hbase/pull/7445/files
Here instead of ReplicationEndpoint handling flush and offset update, ReplicationSourceShipper is using time based and size based logic to flush and update replication offset
Please ignore the failing tests